dark_zoul/YoutubePlaylistSync
1
0
Fork 0
mirror of https://github.com/darkzoul5/YoutubePlaylistSync.git synced 2026-09-18 20:43:54 +03:00
Code Packages Releases Activity

ci: switch workflow path filters to paths-ignore

Browse Source
This commit is contained in:
dark_zoul
2026-06-11 13:05:51 +03:00
parent 48bcf2c9df
commit 22756f35db
3 changed files with 23 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/lint_ruff.yml
+11 -1
View File
@@ -2,7 +2,17 @@ name: Lint Python code
on: on:
push: push:
branches:
- main
paths-ignore:
- "assets/**"
- "README.md"
pull_request: pull_request:
branches:
- main
paths-ignore:
- "assets/**"
- "README.md"
jobs: jobs:
lint: lint:
@@ -15,4 +25,4 @@ jobs:
run: pip install ruff run: pip install ruff
- name: Run linter - name: Run linter
run: ruff check . run: ruff check .
.github/workflows/unit-tests.yml
+6 -12
View File
@@ -5,21 +5,15 @@ on:
push: push:
branches: branches:
- main - main
paths: paths-ignore:
- "src/**" - "assets/**"
- "tests/**" - "README.md"
- "pyproject.toml"
- "pytest.ini"
- "ytpl-sync-entry.py"
pull_request: pull_request:
branches: branches:
- main - main
paths: paths-ignore:
- "src/**" - "assets/**"
- "tests/**" - "README.md"
- "pyproject.toml"
- "pytest.ini"
- "ytpl-sync-entry.py"
concurrency: concurrency:
group: ${{ github.workflow }}-${{ github.ref }} group: ${{ github.workflow }}-${{ github.ref }}
plans/mp3 metadata plan.md
+6 -6
View File
@@ -11,7 +11,7 @@
- Write useful MP3 metadata for downloaded playlist items without affecting video-only downloads. - Write useful MP3 metadata for downloaded playlist items without affecting video-only downloads.
- Keep the implementation reliable when optional fields are missing. - Keep the implementation reliable when optional fields are missing.
- Preserve successful downloads even when metadata embedding partially fails. - Preserve successful downloads even when metadata embedding partially fails.
- Provide a setting to enable or disable MP3 metadata embedding. - Provide a per-playlist setting to enable or disable MP3 metadata embedding.
## Required Metadata ## Required Metadata
@@ -26,7 +26,7 @@
## Configuration Requirement ## Configuration Requirement
- Add a setting to turn MP3 metadata embedding on or off. - Add a per-playlist setting to turn MP3 metadata embedding on or off.
- Default should be explicitly defined during implementation; recommended default is `enabled` for new configs. - Default should be explicitly defined during implementation; recommended default is `enabled` for new configs.
- The setting should only affect `.mp3` metadata writing and should not change download selection, extraction, or `.mp4` handling. - The setting should only affect `.mp3` metadata writing and should not change download selection, extraction, or `.mp4` handling.
@@ -68,7 +68,7 @@
- Ensure the enriched `PlaylistItem` reaches the download job and post-processing stage. - Ensure the enriched `PlaylistItem` reaches the download job and post-processing stage.
- Keep this propagation in-memory unless restart-safe metadata persistence becomes necessary later. - Keep this propagation in-memory unless restart-safe metadata persistence becomes necessary later.
- Avoid changing unrelated sync behavior for video-only items. - Avoid changing unrelated sync behavior for video-only items.
- Carry the MP3 metadata enabled/disabled setting into the post-processing step. - Carry the per-playlist MP3 metadata enabled/disabled setting into the post-processing step.
### 4. Add an MP3 tag writer ### 4. Add an MP3 tag writer
@@ -109,8 +109,8 @@
### 8. Add configuration surface ### 8. Add configuration surface
- Add the new setting to the config model and default config output. - Add the new per-playlist setting to the playlist config model and default config output.
- Expose the setting in the GUI/settings surface if MP3 behavior is already user-configurable there. - Expose the setting in the playlist configuration UI, not as a global app setting.
- Keep the naming explicit, for example `write_mp3_metadata` or `embed_mp3_metadata`. - Keep the naming explicit, for example `write_mp3_metadata` or `embed_mp3_metadata`.
## Error Handling Rules ## Error Handling Rules
@@ -137,7 +137,7 @@
## Documentation Updates ## Documentation Updates
- Document that MP3 tags are written only for `.mp3` outputs. - Document that MP3 tags are written only for `.mp3` outputs.
- Document the new setting that enables or disables MP3 metadata embedding. - Document the new per-playlist setting that enables or disables MP3 metadata embedding.
- Document the field fallback rules, especially artist and album behavior. - Document the field fallback rules, especially artist and album behavior.
- Document that album art comes from the video thumbnail, not playlist artwork. - Document that album art comes from the video thumbnail, not playlist artwork.
- Document that some YouTube items will not expose album or genre information. - Document that some YouTube items will not expose album or genre information.