From 22756f35dba64cf2e2ee299740f977c80d7fbf2b Mon Sep 17 00:00:00 2001 From: DARKZOUL5 Date: Thu, 11 Jun 2026 13:05:51 +0300 Subject: [PATCH] ci: switch workflow path filters to paths-ignore --- .github/workflows/lint_ruff.yml | 12 +++++++++++- .github/workflows/unit-tests.yml | 18 ++++++------------ plans/mp3 metadata plan.md | 12 ++++++------ 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/.github/workflows/lint_ruff.yml b/.github/workflows/lint_ruff.yml index d913657..82d4903 100644 --- a/.github/workflows/lint_ruff.yml +++ b/.github/workflows/lint_ruff.yml @@ -2,7 +2,17 @@ name: Lint Python code on: push: + branches: + - main + paths-ignore: + - "assets/**" + - "README.md" pull_request: + branches: + - main + paths-ignore: + - "assets/**" + - "README.md" jobs: lint: @@ -15,4 +25,4 @@ jobs: run: pip install ruff - name: Run linter - run: ruff check . \ No newline at end of file + run: ruff check . diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 45aba3e..f9fa3f8 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -5,21 +5,15 @@ on: push: branches: - main - paths: - - "src/**" - - "tests/**" - - "pyproject.toml" - - "pytest.ini" - - "ytpl-sync-entry.py" + paths-ignore: + - "assets/**" + - "README.md" pull_request: branches: - main - paths: - - "src/**" - - "tests/**" - - "pyproject.toml" - - "pytest.ini" - - "ytpl-sync-entry.py" + paths-ignore: + - "assets/**" + - "README.md" concurrency: group: ${{ github.workflow }}-${{ github.ref }} diff --git a/plans/mp3 metadata plan.md b/plans/mp3 metadata plan.md index 228df14..8272b55 100644 --- a/plans/mp3 metadata plan.md +++ b/plans/mp3 metadata plan.md @@ -11,7 +11,7 @@ - Write useful MP3 metadata for downloaded playlist items without affecting video-only downloads. - Keep the implementation reliable when optional fields are missing. - Preserve successful downloads even when metadata embedding partially fails. -- Provide a setting to enable or disable MP3 metadata embedding. +- Provide a per-playlist setting to enable or disable MP3 metadata embedding. ## Required Metadata @@ -26,7 +26,7 @@ ## Configuration Requirement -- Add a setting to turn MP3 metadata embedding on or off. +- Add a per-playlist setting to turn MP3 metadata embedding on or off. - Default should be explicitly defined during implementation; recommended default is `enabled` for new configs. - The setting should only affect `.mp3` metadata writing and should not change download selection, extraction, or `.mp4` handling. @@ -68,7 +68,7 @@ - Ensure the enriched `PlaylistItem` reaches the download job and post-processing stage. - Keep this propagation in-memory unless restart-safe metadata persistence becomes necessary later. - Avoid changing unrelated sync behavior for video-only items. -- Carry the MP3 metadata enabled/disabled setting into the post-processing step. +- Carry the per-playlist MP3 metadata enabled/disabled setting into the post-processing step. ### 4. Add an MP3 tag writer @@ -109,8 +109,8 @@ ### 8. Add configuration surface -- Add the new setting to the config model and default config output. -- Expose the setting in the GUI/settings surface if MP3 behavior is already user-configurable there. +- Add the new per-playlist setting to the playlist config model and default config output. +- Expose the setting in the playlist configuration UI, not as a global app setting. - Keep the naming explicit, for example `write_mp3_metadata` or `embed_mp3_metadata`. ## Error Handling Rules @@ -137,7 +137,7 @@ ## Documentation Updates - Document that MP3 tags are written only for `.mp3` outputs. -- Document the new setting that enables or disables MP3 metadata embedding. +- Document the new per-playlist setting that enables or disables MP3 metadata embedding. - Document the field fallback rules, especially artist and album behavior. - Document that album art comes from the video thumbnail, not playlist artwork. - Document that some YouTube items will not expose album or genre information.